Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next cloud deck table scrolling #5377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −0
Open

Next cloud deck table scrolling #5377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d77f24c
Initial commit
adshrest Dec 14, 2023
df22bf9
Pending changes exported from your codespace
adshrest Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions css/deck.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@
background-image: url(../img/deck.svg);
filter: var(--background-invert-if-dark);
}

/* Add horizontal scrollbar for tables in card descriptions */
.card-description table {
width: 100%; /* Ensure the table takes 100% width of the container */
overflow-x: auto; /* Enable horizontal scrolling */
}
Comment on lines +11 to +15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this duplicate rule over here, best would be to only adjust this in the component that renders the table which would be here:

deck/src/components/card/Description.vue

Line 52 in 9e41cb1

<div v-if="textAppAvailable" class="description__text">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the scoping might limit the css rule so you probably need something like

.description__text:deep(table) {

6 changes: 6 additions & 0 deletions src/components/cards/CardItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,12 @@
}
}

/* Add horizontal scrollbar for tables in card descriptions */
.description-container table {
width: 100%;

Check failure on line 439 in src/components/cards/CardItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Mixed spaces and tabs
overflow-x: auto;

Check failure on line 440 in src/components/cards/CardItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Mixed spaces and tabs
}

Check failure on line 441 in src/components/cards/CardItem.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Mixed spaces and tabs

@media (prefers-color-scheme: dark) {
.card {
@include dark-card;
Expand Down