editable inline card titles #592
Conversation
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 52 52
Lines 1969 1969
=======================================
Hits 1486 1486
Misses 483 483 |
templates/part.board.mainView.php
Outdated
| ng-click="c.status.editCard=true">{{cardservice.get(c.id).title}}</span> | ||
|
|
||
| <form ng-if="c.status.editCard" ng-submit="cardservice.update(c); c.status.editCard=false"> | ||
| <input type="text" placeholder="<?php p($l->t('Add a new card')); ?>" |
There was a problem hiding this comment.
Can you add the input-inline class here, this should make the input look like the other inline editing fields. Also we need some adjustment so that the height and text of the card is not flipping around when changing from view to edit mode.
There was a problem hiding this comment.
Added the class, struggling with controlling the height and text. Not sure where the extra height is coming from. Any advice on how to track it down? css issues like this is usually a struggle for me.
|
@nextcloud/deck "Also we need some adjustment so that the height and text of the card is not flipping around when changing from view to edit mode." - juliushaertl Any css guru's out there able to help me out here with the height / width jumps when the control switches from a span to input element? see line 79 on templates/part.board.mainView.php it is driving me bonkers. |
|
AHA! @juliushaertl take a look at my last commit, let me know if that is satisfactory for the "jumps". |
js/controller/BoardController.js
Outdated
| @@ -125,7 +125,7 @@ app.controller('BoardController', function ($rootScope, $scope, $stateParams, St | |||
| $scope.filterData('-lastModified', $scope.searchText); | |||
| } else { | |||
| $scope.filterData('order', $scope.searchText); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Whitespace issues again ;)
js/controller/BoardController.js
Outdated
| @@ -136,7 +136,7 @@ app.controller('BoardController', function ($rootScope, $scope, $stateParams, St | |||
| if ($scope.stacks === undefined) { | |||
| return; | |||
| } | |||
| angular.copy(StackService.getData(), $scope.stacks); | |||
| angular.copy(StackService.getData(), $scope.stacks); | |||
templates/part.board.mainView.php
Outdated
| <form ng-if="s.status.editStack" ng-submit="stackservice.update(s); s.status.editStack=false"> | ||
| <input type="text" placeholder="<?php p($l->t('Add a new stack')); ?>" | ||
| ng-blur="stackservice.update(s); s.status.editStack=false" ng-model="s.title" | ||
| autofocus-on-insert required maxlength="100" /> | ||
| </form> | ||
| </form> |
|
@Nebri I've pushed a commit to fix the padding issue for the input field. Good to be merged, once the whitespace issues are fixed. 👍 |
|
@juliushaertl I found the user settings in visual studio code to automatically trim whitespaces from the end of a line. This should murder the whitespace issue for me. Requested changes are in. |
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
juliushaertl
force-pushed
the
251-card-title-inline
branch
from
cad9f93
to
d17d0ec
Compare
Signed-off-by: Ryan Fletcher ryan.fletcher@codepassion.ca
Summary
closes issue: #251
TODO
Checklist