perf: Avoid fetching labels and owner details on permission check #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running integration tests locally reduces the query count, checking in another PR. |
juliushaertl
force-pushed
the
perf/permission-skip-enhance
branch
from
a7ef797
to
2b70479
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Also on #6011, need to update the baseline |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
perf/permission-skip-enhance
branch
from
2b70479
to
d4ea088
Compare
elzody
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save some queries as well as a decent amount of CPU time when checking card permissions during file system setup for deck shares.
On our instance this is around 5% of total CPU time in a 1h sample during non-peak times.
Checklist