Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix: Avoid optional before required parameter #6045

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[stable28] fix: Avoid optional before required parameter #6045

merged 1 commit into from
Jun 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 28, 2024

Backport of PR #5794

@juliushaertl @backportbot
fix: Avoid optional before required parameter
d284bea 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@backportbot backportbot bot added this to the 1.11.0 (Nextcloud 28) milestone Jun 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 66558 was 66366 (+0.28%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@juliushaertl juliushaertl merged commit ec50af9 into stable28 Jun 28, 2024
30 of 31 checks passed
@juliushaertl juliushaertl deleted the backport/5794/stable28 branch June 28, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

Assignees

@juliushaertl juliushaertl

Labels
3. to review bug
Projects
None yet
Milestone
1.11.0 (Nextcloud 28)
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@juliushaertl