Skip to content

Commit

Permalink
Fix KDEInstallDirs deprecation warnings
Browse files Browse the repository at this point in the history
Get rid of a bunch of such warnings from configuring the Dolphin plugin:

CMake Deprecation Warning at /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:345 (message):
  BIN_INSTALL_DIR is deprecated, use KDE_INSTALL_BINDIR instead.
Call Stack (most recent call first):
  /usr/share/ECM/kde-modules/KDEInstallDirs.cmake:433 (_define_relative)
  shell_integration/dolphin/CMakeLists.txt:23 (include)

Modified from owncloud/client#6922

Original author: Dominik Schmidt <dev@dominik-schmidt.de>
  • Loading branch information
Chih-Hsuan Yen committed Dec 28, 2018
1 parent b46ee79 commit 1361c30
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions shell_integration/dolphin/CMakeLists.txt
Expand Up @@ -20,7 +20,12 @@ set_package_properties(DolphinVcs PROPERTIES
PURPOSE "Provides plugin interfaces for Dolphin."
)

set(KDE_INSTALL_DIRS_NO_DEPRECATED TRUE)
include(KDEInstallDirs)
# Before KF5 5.54, kcoreaddons_add_plugin uses deprecated VAR PLUGIN_INSTALL_DIR
# when that is fixed and you want to remove this workaround,
# you need to _require_ the new enough kcoreaddons
set(PLUGIN_INSTALL_DIR "${KDE_INSTALL_PLUGINDIR}")
include(KDECMakeSettings)
include(KDECompilerSettings)
include(ECMMarkNonGuiExecutable)
Expand Down

0 comments on commit 1361c30

Please sign in to comment.