Simplify loop to write bytes to password

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
nextcloud · Jul 21, 2023 · 67ef758 · 67ef758
1 parent a306ace
commit 67ef758
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
@@ -63,10 +63,9 @@ QString createRandomPassword()
 
     RAND_bytes(unsignedCharArray.data(), numChars);
 
-    for (auto i = 0; i < numChars; i++) {
-        auto byte = unsignedCharArray[i];
-        byte %= asciiRange + 1;
-        byte += asciiMin;
+    for (const auto newChar : unsignedCharArray) {
+        // Ensure byte is within asciiRange
+        const auto byte = (newChar % (asciiRange + 1)) + asciiMin;
         passwd.append(byte);
     }