Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and replace file leads to deletion and creation of new file #3240

Closed
biva opened this issue Apr 30, 2021 · 17 comments · Fixed by #3311
Closed

Rename and replace file leads to deletion and creation of new file #3240

biva opened this issue Apr 30, 2021 · 17 comments · Fixed by #3311
Labels

Comments

@biva
Copy link

biva commented Apr 30, 2021

What happens

  1. Sync the file docu.doc (possibly, docu.doc has a shared public link, but it)
  2. Edit this file and close it
  3. Rename the file docu2.doc
  4. Sometimes (not always) docu2.doc is considered as newly created document (without any previous version and without any shared link) and docu.doc is deleted.

What should happen

docu2.doc should be the renamed version of docu.doc and keep the old versions and the shared links.

Similar issues

I have looked for existing issues:

Config

NC21 (Debian, Apache)
Desktop 3.1.3 on Windows 10

@biva biva added the bug label Apr 30, 2021
@joholm2
Copy link

joholm2 commented May 6, 2021

Hi, sorry I missed this one when I created my issue recently.
On the other hand mine may be more useful because I have found the error which is causing it.
Please see #3270 - especially my second post there.

@allexzander
Copy link
Contributor

allexzander commented May 6, 2021

@biva Can you share logs that got created right after you experience this issue?

Also, is this on 3.2.x only?

@joholm2
Copy link

joholm2 commented May 6, 2021

@allexzander - please see the bug report I created and linked to above. It has not only logs but pinpoints the fault.

Please see #3270 - especially my second post there.

@allexzander
Copy link
Contributor

@joholm2 Thx I've noticed that issue too. However, when dealing with such cases, I prefer having logs from all users that encountered seemingly same issue to exclude the chance that we're dealing with different issues having identical symptoms.

@joholm2
Copy link

joholm2 commented May 6, 2021

@allexzander Ok, thanks - understood.

@biva
Copy link
Author

biva commented May 11, 2021

I have created a file test.txt and renamed it several times in a row. I see the following files deleted in the Web UI:
image
The last name is fez.txt:
image

@allexzander @joholm2 I would like to share the log with you but I'd be more comfortable to share per email, not in a public place: would that be possible?

@biva
Copy link
Author

biva commented May 12, 2021

For information, this is not on 3.2 only, it happened on previous versions as well.

@allexzander
Copy link
Contributor

@biva Sure. Please send logs to my inbox alex@nextcloud.com

@biva
Copy link
Author

biva commented May 13, 2021

Thanks! I sent you the email with the logs @allexzander Do you think it's the same issue as #3270?

@allexzander
Copy link
Contributor

@biva Received. Thanks. Yes. Looks like we have 3 similar issues on Github. Anyways, I've got the PR with a fix #3311

And, here you can get an early test build before I release the fix, if interested https://cloud.nextcloud.com/s/g6acjp9HGNPweL5

@biva
Copy link
Author

biva commented May 14, 2021

Congrats :) I'm just wondering if your PR fixes a bug that happens on 3.2 only? Because in our situation, this bug is present for a long time with previous versions.

@allexzander
Copy link
Contributor

Congrats :) I'm just wondering if your PR fixes a bug that happens on 3.2 only? Because in our situation, this bug is present for a long time with previous versions.

@biva You will have to update to 3.2.2 when it's out. We won't be rebuilding 3.2.

@biva
Copy link
Author

biva commented May 14, 2021

Sorry for the misunderstanding. What I meant is: "is this bug [the one solved in the PI] related to 3.2 only? Or was this bug present in previous versions?"

Indeed, we see this bug for a long time: the bug mentioned in this issue #3240 is not specific to 3.2 and virtual folders.

(I fully understand that previous versions will not include the fix, no problem for us)

@biva
Copy link
Author

biva commented Jun 28, 2021

Hello @allexzander I just installed 3.2.3 on Windows 10 and the problem is not solved: I still have the same issue. Does this version include the fix? (server is 21.0.2)

@biva
Copy link
Author

biva commented Jun 28, 2021

For information in order to reproduce the issue:

  1. Create a file test.txt
  2. Keep renaming it very fast, edit it, change the content, save it, rename it... Do this several times, very fast, without leaving time to the desktop client to finalise the sync.
  3. Check the web UI: you should find one or several deleted files corresponding to this file (while no file should be created/deleted)

It might look a weird scenario to do this, but that's to reproduce the issue easily. For large files, it's really possible that this happens without making these weird fast changes and savings.

@biva
Copy link
Author

biva commented Jul 13, 2021

Hello @allexzander I tested it with 3.2.4, still the same issue :( Could you please provide any update?

Thanks!

@biva
Copy link
Author

biva commented Jul 13, 2021

Could you also please reopen this issue as it's still there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants