Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Nextcloud Extensions on MacOS #3967

Closed
pszypowicz opened this issue Nov 12, 2021 · 12 comments 路 Fixed by #3969
Closed

Multiple Nextcloud Extensions on MacOS #3967

pszypowicz opened this issue Nov 12, 2021 · 12 comments 路 Fixed by #3969

Comments

@pszypowicz
Copy link

How to use GitHub

  • Please use the 馃憤 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

There should be just one Nextcloud Extensions process along side the Nextcloud process on MacOS.

Actual behaviour

Actually over time the Nextcloud Extensions will get multiplied.

As a side note, this is a native apple silicone 3.4.0rc1 release but I'm sure this also happen before on intel version.

Steps to reproduce

  1. Run Nextcloud on MacOS
  2. After a while (sometime day/days and with sleep/hibernation in between) the Nextcloud Extensions process will get multiplied.
  3. Open "Activity Monitor" on mac, filter the "Nextcloud" keyword and see the result

Zrzut ekranu 2021-11-12 o 09 35 40

Client configuration

Client version:
3.4.0.rc1

Operating system:
MacOS

OS language:
Polish/English

@pszypowicz pszypowicz added the bug label Nov 12, 2021
FlexW pushed a commit that referenced this issue Nov 12, 2021
Fix: #3967

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
FlexW pushed a commit that referenced this issue Nov 15, 2021
Fix: #3967

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@FlexW
Copy link

FlexW commented Nov 15, 2021

I can't reproduce it. I see after the installation for a short time (1 to 2 seconds) two Nextcloud Extension processes. But I now had the client running for the whole weekend, and I still have just one Nextcloud Extensions process. I've created a pr to also compile the finder extensions for arm and x86 and made them a universal binary too. Maybe that was causing problems. If you want, I can create a test build for you to test it.

@pszypowicz
Copy link
Author

I'm not sure either what cause it. For example today, after a weekend I had just one process for extension (as it should be).

But on friday this is how it looked like:
Zrzut ekranu 2021-11-12 o 14 52 28

Interestingly enough, extensions look like it is already compiled for an AS.

If you provide a new package RC, I'm happy to test it.

@gennaios
Copy link

On 3.3.6, I checked and also have more than one Extensions process. Two. Looks to be normal:

The system may also launch additional copies of your extension whenever an Open or Save dialog is displayed. This means that the user may have multiple copies of your extension running at once, and some may be very short lived. Therefore, it鈥檚 generally best if the extension focuses on handling the badges, contextual menus, and toolbar buttons. Place in a separate service (a Login Item or Launch Agent) any code that performs the sync, updates state, or communicates with remote data sources. This approach ensures that there is only one syncing service running at a time.

https://developer.apple.com/library/archive/documentation/General/Conceptual/ExtensibilityPG/Finder.html

nextcloud-command pushed a commit that referenced this issue Nov 16, 2021
Fix: #3967

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@FlexW
Copy link

FlexW commented Nov 16, 2021

@gennaios Thanks for the link. @pszypowicz Yes, I saw that but it was definitely not compiled for both archs. Here is the build: https://cloud.nextcloud.com/s/PykMNZ98bW4CMnH

@gennaios
Copy link

@FlexW thanks for the build. I can wait until release. Do you know if the upcoming update will be built as Universal?

@FlexW
Copy link

FlexW commented Nov 17, 2021

@gennaios Very likely, if we do not find a major issue.

@pszypowicz
Copy link
Author

@FlexW Thanks. This build seems to behave better on my mac. I'm looking forward to 3.4.0 final release :)

mgallien pushed a commit that referenced this issue Nov 30, 2021
Fix: #3967

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@zfdang
Copy link

zfdang commented Jun 13, 2022

Is it because I'm also using path finder? There are more than 10 Nextcloud extensions running

@zfdang
Copy link

zfdang commented Jun 20, 2022

Screen Shot 2022-06-20 at 20 41 31

@telephon
Copy link

telephon commented Aug 31, 2022

same here. I noticed them because battery says "high energy impact" (although this is not visible in the list).

What are they for?

Screenshot 2022-08-31 at 18 43 03

@telephon
Copy link

@mgallien this continues to be an issue. In terms of energy impact, this should be addressed.
I am on macOS 12.6.2, with a new nextcloud client installed.

Could it be caused by being offline? Some years ago, there was trouble in nextcloud client whenever one wasn't online.

@mgallien
Copy link
Collaborator

@mgallien this continues to be an issue. In terms of energy impact, this should be addressed. I am on macOS 12.6.2, with a new nextcloud client installed.

Could it be caused by being offline? Some years ago, there was trouble in nextcloud client whenever one wasn't online.

my idea is that we revisit this once we have a release out based on the next Qt major version that is natively supporting the newest Apple platforms and has generally much improved code
that would mean either testing the dailies once #4584 is merged or the major release after 3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants