Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Linux Desktop client does not unlock files #5537

Closed
6 of 8 tasks
sushifrick opened this issue Mar 20, 2023 · 1 comment · Fixed by #5841
Closed
6 of 8 tasks

[Bug]: Linux Desktop client does not unlock files #5537

sushifrick opened this issue Mar 20, 2023 · 1 comment · Fixed by #5841
Assignees
Labels
2. to review approved bug approved by the team bug

Comments

@sushifrick
Copy link

⚠️ Before submitting, please verify the following: ⚠️

Bug description

In my test cases the linux desktop client does add a lock if a shared file is locked via the web interface or via the desktop integration, but after releasing the lock, the lock on the client still exists. On windows this works in my tests. I also testes to thare a single file instead of a folder, but with the same behavior.

I am running server version "25.0.4 Enterprise" and linux client "3.7.4" on archlinux. The Windows test case is still on "3.6.4" but showing the correct behavior. Unfortunately I cannot update the client, as it is on a terminal server I don't have admin permission on and the client is installed via an AD group policy.

I am not sure if the lock feature is covered by our GEANT subscription, but if it helps I can drop a case into the customer ticket system as well.

Steps to reproduce

  1. Create a shared folder.
  2. Lock a file in that folder, either using the web interface to lock or edit a file, or the desktop client.
  3. The Lock is added to both windows (+r bit) and linux (-w bit) test accounts.
  4. Unlock the file, again via web or desktop.
  5. The lock is removed on windows (-r bit), but still is read only on linux.
  6. Forcing a sync does not help as well as restarting the desktop client.
  7. I can only unlock the file by setting the write bit by hand or by removing the folder from selective sync and resync the whole folder, so the server knows about the unlocked state.

See attached the linux client log.
client_debug_log_lockfile.zip

Expected behavior

Releasing the lock removes the write lock on both linux and windows.

Which files are affected by this bug

lock-test.txt

Operating system

Linux

Which version of the operating system you are running.

Archlinux

Package

Distro package manager

Nextcloud Server version

25.0.4 Enterprise

Nextcloud Desktop Client version

3.7.4

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 3.3.6 to 3.4.0)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

No response

Additional info

No response

@sushifrick
Copy link
Author

As a follow up - once the file is changed again after unlocking, the unlocked status will be synced correctly. But if the file is only unlocked and never changed again, the file stays locked locally.

@mgallien mgallien self-assigned this Jun 1, 2023
@mgallien mgallien added 2. to review approved bug approved by the team bug and removed 0. Needs triage labels Jun 23, 2023
mgallien added a commit that referenced this issue Jun 28, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jun 29, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jul 3, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jul 10, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jul 10, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jul 11, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien added a commit that referenced this issue Jul 12, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Jul 12, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
camilasan pushed a commit that referenced this issue Jul 24, 2023
make sure that a file locked that would not be modifiable by the
current client is read-only on storage

also make sure we make a file read/write when modification can happen
again

Close #5537

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. to review approved bug approved by the team bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants