Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-End Encryption enabled automatically #917

Closed
schiessle opened this issue Dec 3, 2018 · 9 comments
Closed

End-to-End Encryption enabled automatically #917

schiessle opened this issue Dec 3, 2018 · 9 comments

Comments

@schiessle
Copy link
Member

schiessle commented Dec 3, 2018

I'm just sitting in front of my computer and without interacting with the sync client this window pops up:

image

I didn't enabled any end-to-end encryption. Could it be triggered by someone else enabled end-to-end encryption on a shared folder?

@MorrisJobke
Copy link
Member

I didn't enabled any end-to-end encryption. Could it be triggered by someone else enabled end-to-end encryption on a shared folder?

Just to clarify: on the server e2ee app was enabled again (was disabled in a past upgrade).

@schiessle
Copy link
Member Author

normally the key creation has to be triggered by the client and the client should only trigger it once I set at least one folder to e2e not just because the app was enabled on the server

@tobiasKaminsky
Copy link
Member

Could it be triggered by someone else enabled end-to-end encryption on a shared folder?

This should not be possible right now, as it is not supported at all.
If someone can really share a e2e folder, than this is a bug right now.

@schiessle
Copy link
Member Author

schiessle commented Dec 3, 2018

Discussing this with @tobiasKaminsky I think the client detects the new capability and tries to fetch an existing key from the server, which makes sense, because if the user has some encrypted folders they want to access it. But in case there is no existing key, the initial creation should not be triggered and instead postponed until the user enabled encryption for one folder.

@tobiasKaminsky
Copy link
Member

Now it happened to me also.
As I have 4 accounts, I now do not know for which account the mnemonic is…
--> please also include account name into this dialog

@rullzer
Copy link
Member

rullzer commented Dec 4, 2018

There is a ticket already about this somewhere. This was how is was specified:
See https://github.com/nextcloud/end_to_end_encryption_rfc/blob/master/RFC.md#adding-an-end-to-end-encrypted-device and https://github.com/nextcloud/end_to_end_encryption_rfc/blob/master/RFC.md#further-devices

We could improve here sure. But it is not high on the list of things to fix.

@augustseptember
Copy link

@tobiasKaminsky had the same confusion about the mnemonics: #753

@jancborchardt
Copy link
Member

Also, this should not just pop up, but only when it’s relevant. For me it showed when I connected the account, where it’s very irrelevant.

It should show only when I either want to encrypt a folder myself, or receive an encrypted folder as a share and want to open it.

Otherwise we ask people to write something down that they will not care about at that moment and then not have anymore when they really need it.

@er-vin
Copy link
Member

er-vin commented May 19, 2020

Hello,

I think this issue is properly addressed with PR #1241 so closing now.

Regards.

@er-vin er-vin closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants