Added a nice UI for the E2E-enabled account first connect #1241
Conversation
Instead of immediately popping up the mnemonic dialogue, only show a notification bar on the account setup page. For the cases where the user does not want to use E2E, this is significantly less intrusive than the old approach.
|
This is what it looks like on Windows (ignore the system exclude file message)
|
|
What do you think @jancborchardt? |
|
Good stuff @ivan-cukic! Only details:
Thanks a lot! 🚀 |
|
I first wrote it with the dashes, and then saw that it is written without dashes in a few places, so I ended up removing them. Will put them back. WRT 'setup', I wanted to ask whether anyone has a better idea for the button title as it is not really setting anything up. Yes, the icon is awkward on Windows. It uses |
|
Nice work 👍
How about "Enable" or "Activate"? (Perhaps "Enable..." / "Activate..." to signal there's something more to adjust than just a click.) While writing this I feel I'd personally prefer "Enable" rather than "Activate"^^ |
- Text changed to "Enable..." instead of "Setup" - The close icon follows NC style - "end-to-end" instead of "end to end" Signed-off-by: Ivan Čukić <ivan.cukic@kde.org>
|
@misch7 to be even more descriptive, the button should include what it will enable, like "Enable encryption". |
Even though this could be clear to understand from the notification context (see screenshot) I think you're right, this would improve the button to be super clear to the user. And it would still be short enough. |
|
Message changed. |
src/gui/accountsettings.cpp
Outdated
| { | ||
| ui->encryptionMessage->setText(tr("This account supports end-to-end encryption")); | ||
|
|
||
| QAction *mnemonic = new QAction(tr("Enable encryption..."), this); |
There was a problem hiding this comment.
| QAction *mnemonic = new QAction(tr("Enable encryption..."), this); | |
| QAction *mnemonic = new QAction(tr("Enable encryption"), this); |
The ellipsis is not really needed here.
There was a problem hiding this comment.
It was requested by @camilasan to indicate that it opens up a new window
There was a problem hiding this comment.
Hm, I wouldn’t expect that from "…" a simple ellipsis. Also other buttons like "Add folder sync connection" and "Edit ignored files" which open a new window don’t do that. So I’d cut it for less noise.
Instead of immediately popping up the mnemonic dialogue,
only show a notification bar on the account setup page.
For the cases where the user does not want to use E2E,
this is significantly less intrusive than the old approach.
This is related to #917 and #753