slideshow buttons

[IzabelaBakollari]

Added slideshow buttons and changed color of the link "Host your own server".

[jancborchardt]

Looks great design-wise! :)

[DominiqueFuchs]

After digging this PR out I ran some tests to see if this could happily be merged after the positive design reactions.

Unfortunately, several months later the result is a mess without further modifications (screen attached):

• Redundant hosting link (thus resulting in broken layout)
• The arrows only look good on the dark background, Windows-white is obviously no good contrast

Any comments if fixing and adaption to current state is still desired? If yes, I could do this (should @IzabelaBakollari be out of reach in the meantime), otherwise I'd close this.

[jancborchardt]

@DominiqueFuchs would really be cool to fix this if you are up for it. :) It was reported as an accessibility issue.

[DominiqueFuchs]

Done:

• Recreated the prev/next-buttons, as the original svg contained reduced blur filters as shadows that are not supported by the Qt SVG renderer, resulted in strange looks when viewed at high dpi or scaled up. Thus I made a new vector image with a slightly thicker arrow instead, rounded the corners a bit to fit into the much rounding in the current CD and applied a slight gradient to maintain 'intuitive' highlighting. Also, I used the NC blue as a base, as this gives good contrast on every background that makes sense here
• Implemented in wizard page layout from master
• Speaking of accessibility, I embedded the 'Host your own server' link in his own widget - otherwise it is not tab-accessible (QLabels itself aren't)

Builds fine everywhere, looks fine on Windows (only build/test system with a GUI on my side ATM)

Button svg:

Build result:

🦊 approve, @jancborchardt ?

[jancborchardt]

@DominiqueFuchs nice work! :)

The only thing is that there’s too much blue there. Only the header and the primary button (in this case "Register with a provider") should be blue now, but not the prev/next icons, and also not the icons and the text. So likely one version for light backgrounds and one for dark.

But we could also do that in a separate pull request to do small steps but quickly – also cause text and icons being blue was like that before already. :)

[DominiqueFuchs]

@jancborchardt Sorry, before your last comment I did not notice the referenced issue, thanks for clarifying anyway!

Summary of changes:

• Desired design changes
• Implementation of a helper function in theme.h/theme.cpp to retrieve a QIcon resource based on current OS theming state (meaning here bg color of the widget, which is actually only OS controlled as our current 'app theming' only applies to systray icons).

Windows (Gnome also tested, runs fine but looks essentially the same as expected):

KDE:

[jancborchardt]

Good stuff! 👍 I have some more design ideas for the setup process, but that’s a follow-up pull request, maybe best at the conf or at a contributor week. :)