Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share link fixing #1191

Merged
merged 3 commits into from Apr 12, 2019
Merged

Share link fixing #1191

merged 3 commits into from Apr 12, 2019

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Apr 6, 2019 •
edited

to do

  • add screenshots to PR

Initial state:
initial_state

After first share:
sharing

  • clean up code
  • more testing

@camilasan camilasan requested a review from rullzer April 11, 2019 20:53
@camilasan camilasan added this to In Review | Testing in Desktop Client 2.5 Series via automation Apr 11, 2019
@camilasan camilasan added this to the 2.5.3 🐛 Bug fixes milestone Apr 11, 2019
@camilasan camilasan force-pushed the bugfix/1172/share-link branch 2 times, most recently from e30750d to 8d002d1 Compare April 12, 2019 11:55
rullzer
rullzer approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this

Camila San added 3 commits April 12, 2019 14:17
Fixes deleting of one single link share.
0fed1cc 
Signed-off-by: Camila San <hello@camila.codes>
Refactores sharing link to support multiple share links.
e07c472 
Signed-off-by: Camila San <hello@camila.codes>
Disable options in share dialog if account state changes.
35114cf 
Signed-off-by: Camila San <hello@camila.codes>
@rullzer rullzer merged commit 6a63d8f into master Apr 12, 2019
Desktop Client 2.5 Series automation moved this from In Review | Testing to Merged | Done | Release! Apr 12, 2019
@rullzer rullzer deleted the bugfix/1172/share-link branch April 12, 2019 12:31
@sws-it sws-it mentioned this pull request Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
2. to review
Projects
No open projects
Desktop Client 2.5 Series
  
Merged | Done | Release!
Milestone
2.5.3 🐛 Bug fixes
Development

Successfully merging this pull request may close these issues.

Unable to unshare link by pressing "Enable"
2 participants
@camilasan @rullzer