-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify cmake command to make copy-pastable #1212
Conversation
Thanks @jancborchardt, could you rebase the PR? |
Inspiders by your PR I did change the instructions in the wiki: What do you think @jancborchardt? |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
0f53d78
to
d2da7db
Compare
@camilasan looks good, but now the command is not copypastable anymore? As |
I will fix it.
ok, PATH was a bad idea.
My goal was to make it generic. |
d2da7db
to
f4361bd
Compare
Signed-off-by: Camila San <hello@camila.codes>
f4361bd
to
75ccffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking great now! 👍 :)
@camilasan this is what I used some time ago for setting up. For me it worked and made the dev setup process much much simpler. (I think we talked about it some months ago, found I didn’t open a pull request for it back then.)
Please review @nextcloud/desktop