Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cmake command to make copy-pastable #1212

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Conversation

jancborchardt
Copy link
Member

@camilasan this is what I used some time ago for setting up. For me it worked and made the dev setup process much much simpler. (I think we talked about it some months ago, found I didn’t open a pull request for it back then.)

Please review @nextcloud/desktop

@jancborchardt jancborchardt added 2. to review enhancement enhancement of a already implemented feature/code labels Apr 19, 2019
@IzabelaBakollari IzabelaBakollari removed their request for review April 19, 2019 14:20
@camilasan
Copy link
Member

Thanks @jancborchardt, could you rebase the PR?

@camilasan
Copy link
Member

Inspiders by your PR I did change the instructions in the wiki:
https://github.com/nextcloud/desktop/wiki/How-to-compile-the-desktop-client

What do you think @jancborchardt?

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@camilasan camilasan force-pushed the cmake-simplify branch 2 times, most recently from 0f53d78 to d2da7db Compare April 21, 2019 12:36
@jancborchardt
Copy link
Member Author

@camilasan looks good, but now the command is not copypastable anymore? As $PATH does not refer to the environment variable but instead the text you wrote above? I would really go for dead-simple setup, that’s why I just went with ~/desktop-install/ as default path. For people who know how to do it they can still easily change it, for people who just want to build it it will just work. :)

@camilasan
Copy link
Member

@camilasan looks good, but now the command is not copypastable anymore?

I will fix it.

As $PATH does not refer to the environment variable but instead the text you wrote above?

ok, PATH was a bad idea.

I would really go for dead-simple setup, that’s why I just went with ~/desktop-install/ as default path. For people who know how to do it they can still easily change it, for people who just want to build it it will just work. :)

My goal was to make it generic.

Signed-off-by: Camila San <hello@camila.codes>
Copy link
Member Author

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking great now! 👍 :)

@camilasan camilasan merged commit f52f9f0 into master Apr 21, 2019
@jancborchardt jancborchardt deleted the cmake-simplify branch April 21, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. to review enhancement enhancement of a already implemented feature/code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants