Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds parameter to retrieve shares with its reshares. #1247

Merged
merged 3 commits into from
May 27, 2019

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented May 9, 2019

If the initiator or the recipient is not the current user,
show the list of sharees without any options to edit it.

Minor change: updates api to v2.

reshares

@camilasan camilasan added this to the 2.5.3 🐛 Bug fixes milestone May 9, 2019
@camilasan camilasan added this to In Review | Testing in Desktop Client 2.5 Series via automation May 9, 2019
@camilasan camilasan changed the title Backport show reshares for NC16+. Adds parameter to retrieve shares with its reshares. May 10, 2019
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this seems to be correct.
If mentioned test case also works, I am fine.

Camila San added 3 commits May 27, 2019 19:46
If the initiator or the recipient is not the current user,
show the list of sharees without any options to edit it.

Minor change: updates api to v2.

Signed-off-by: Camila San <hello@camila.codes>
It was displaying them only when the current user would edit the share.

Signed-off-by: Camila San <hello@camila.codes>
Signed-off-by: Camila San <hello@camila.codes>
@camilasan camilasan merged commit 1dca017 into master May 27, 2019
Desktop Client 2.5 Series automation moved this from In Review | Testing to Merged | Done | Release! May 27, 2019
@tobiasKaminsky tobiasKaminsky deleted the backport/reshare branch August 19, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Desktop Client 2.5 Series
  
Merged | Done | Release!
Development

Successfully merging this pull request may close these issues.

None yet

2 participants