Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the list of ignored files/symlinks into one Activity notification. #1523

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Merge the list of ignored files/symlinks into one Activity notification. #1523

merged 1 commit into from
Oct 17, 2019

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Oct 17, 2019 •
edited
Loading

ignoredfiles

⚠️ the text in the final version is: "Files from the ignore list as well as symbolic links are not synced. This includes:" instead of "Files listed..."

Related issues #1440, #1437.

Merge the list of ignored files/symlinks into one Activity notification.
8546d53 
Signed-off-by: Camila San <hello@camila.codes>
@camilasan camilasan requested a review from misch7 October 17, 2019 16:48
@camilasan camilasan added 2. to review design enhancement enhancement of a already implemented feature/code labels Oct 17, 2019
This was referenced Oct 17, 2019
Open
Closed
Closed
misch7
misch7 approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@misch7 misch7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

jancborchardt
jancborchardt approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice improvement! This will show the people asking for a split activity view back what we are going for :D

@misch7 misch7 merged commit 87844f5 into master Oct 17, 2019
@misch7 misch7 deleted the improvement/merge-ignored-files-notification branch October 17, 2019 20:04
@jancborchardt jancborchardt mentioned this pull request Oct 26, 2019
Closed
@cbrowet-axway
Copy link

Hi,
This one is listed as being included in 2.6.1, but I still see itemized "The File is listed on the ignore list".
Do I miss something?

Running 2.6.1stable-Win64 (build 20191105)

@misch7
Copy link
Member

misch7 commented Dec 5, 2019

@cbrowet-axway Thank you very much for pointing out to this! 👍

🍒 Cherry-picked to stable-2.6

Will get into tomorrow's 2.6.2 RC1 :)

@misch7 misch7 modified the milestones: 2.6.1, 2.6.2 Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@misch7 misch7 misch7 approved these changes

Assignees
No one assigned
Labels
2. to review design enhancement enhancement of a already implemented feature/code
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilasan @cbrowet-axway @misch7 @jancborchardt