Windows: Fix NSIS language encoding (use UTF-8) #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misch7
added a commit
to nextcloud/client-building
that referenced
this pull request
Sep 16, 2020
See: nextcloud/desktop#2432 The desktop PR needs to be merged first. Signed-off-by: Michael Schuster <michael@schuster.ms>
misch7
added a commit
to nextcloud/client-building
that referenced
this pull request
Sep 16, 2020
The following translation files were never referenced: Catalan Farsi French Hungarian Portuguese Russian SimpChinese Swedish Thai Ukrainian See desktop issue: nextcloud/desktop#2393 And desktop PR: nextcloud/desktop#2432 Signed-off-by: Michael Schuster <michael@schuster.ms>
er-vin
approved these changes
Sep 16, 2020
|
/rebase |
…ges) The old conversion to specific code pages caused display errors (see issue #2393 for Russian). Based on bin/l10n.sh, the files in this commit were converted to UTF-8 using iconv with the following parameters: iconv -f CP1252 -t UTF-8 -o German.nsh German.nsh iconv -f CP1252 -t UTF-8 -o Galician.nsh Galician.nsh iconv -f CP1253 -t UTF-8 -o Greek.nsh Greek.nsh iconv -f CP1250 -t UTF-8 -o Slovenian.nsh Slovenian.nsh iconv -f CP1257 -t UTF-8 -o Estonian.nsh Estonian.nsh iconv -f CP1252 -t UTF-8 -o Italian.nsh Italian.nsh iconv -f CP1252 -t UTF-8 -o PortugueseBR.nsh PortugueseBR.nsh iconv -f CP1252 -t UTF-8 -o Spanish.nsh Spanish.nsh iconv -f CP1252 -t UTF-8 -o Dutch.nsh Dutch.nsh iconv -f CP1252 -t UTF-8 -o Finnish.nsh Finnish.nsh iconv -f CP932 -t UTF-8 -o Japanese.nsh Japanese.nsh iconv -f CP1250 -t UTF-8 -o Slovak.nsh Slovak.nsh iconv -f CP1254 -t UTF-8 -o Turkish.nsh Turkish.nsh iconv -f CP1252 -t UTF-8 -o Norwegian.nsh Norwegian.nsh iconv -f CP852 -t UTF-8 -o Czech.nsh Czech.nsh The installer script nextcloud.nsi in the client-building repo needs the following line (to be added on top): Unicode true Signed-off-by: Michael Schuster <michael@schuster.ms>
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud. This commit removes the unused scripts and "Auto-generated" comments in the translation files. Some files have been modified over time either way and MSI will replace NSIS soon. Signed-off-by: Michael Schuster <michael@schuster.ms>
github-actions
bot
force-pushed
the
fix/nsis-language-encoding
branch
from
1252da1
to
0e1e3a2
Compare
|
AppImage file: Nextcloud-PR-2432-0e1e3a29cef6e4c2bda3a706a2960cfd846337b4-x86_64.AppImage |
|
/backport to stable-3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NSIS language encoding (use UTF-8 instead of Win code pages)
The old conversion to specific code pages caused display errors (see issue #2393 for Russian).
Based on
bin/l10n.sh, the files in this PR were converted to UTF-8 usingiconvwith the following parameters:The installer script
nextcloud.nsiin theclient-buildingrepo needs the following line (to be added on top):Remove unused and outdated NSIS Transifex settings
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.
This PR removes the unused scripts and "
Auto-generated" comments in the translation files.Some files have been modified over time either way and MSI will replace NSIS soon.
Changes required in
client-building& add missing languagesAfter merging this PR, nextcloud/client-building#38 is required to be merged:
It modfies
nextcloud.nsito enable Unicode support.Also adds the following translation files that were never referenced: