Allow server URL to be pre-defined without enforcing it #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misch7
added
enhancement
er-vin
requested changes
Sep 21, 2020
misch7
force-pushed
the
enh/server-url
branch
from
292b386
to
e417259
Compare
|
/rebase |
…modified APPLICATION_SERVER_URL can be either empty or be specified. This commit adds the new CMake option APPLICATION_SERVER_URL_ENFORCE to decide whether to enforce the URL's unmodified use (like before, default: ON) or to allow modification by the user (new). By default APPLICATION_SERVER_URL_ENFORCE is set to ON, to no break with the previous implementation's expectations. If APPLICATION_SERVER_URL is empty, APPLICATION_SERVER_URL_ENFORCE will be ignored by the Account Wizard. The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to manually supply it. Signed-off-by: Michael Schuster <michael@schuster.ms>
github-actions
bot
force-pushed
the
enh/server-url
branch
from
e417259
to
ce71ffe
Compare
|
AppImage file: Nextcloud-PR-2441-ce71ffe9f9c78a84a2698c18ff16923ba4230f96-x86_64.AppImage |
er-vin
approved these changes
Sep 23, 2020
|
/backport to stable-3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow server URL to be pre-defined without enforcing it to be used unmodified
APPLICATION_SERVER_URLcan be either empty or be specified. This commit adds the new CMake optionAPPLICATION_SERVER_URL_ENFORCEto decide whether to enforce the URL's unmodified use (like before, default:ON) or to allow modification by the user (new).By default
APPLICATION_SERVER_URL_ENFORCEis set toON, to no break with the previous implementation's expectations.If
APPLICATION_SERVER_URLis empty,APPLICATION_SERVER_URL_ENFORCEwill be ignored by the Account Wizard.The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to manually supply it.