CMake cleanup #3729
Merged
CMake cleanup #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mgallien
approved these changes
Aug 31, 2021
allexzander
approved these changes
Sep 1, 2021
|
/rebase |
It is provided by CMake itself Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
CMake provides what we wan out of the box Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
OS_SPECIFIC_LINK_LIBRARIES is always empty here Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
nextcloud-command
force-pushed
the
cmakecleanup
branch
from
e2c2d81
to
bc3eb78
Compare
|
AppImage file: Nextcloud-PR-3729-bc3eb7845dacc5cc588e0cff65c76465178a42ca-x86_64.AppImage |
|
This breaks translations, see #4022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.