ShareLinkWidget #3863
Merged
ShareLinkWidget #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
reviewed
Oct 2, 2021
allexzander
reviewed
Oct 2, 2021
FlexW
reviewed
Oct 4, 2021
camilasan
force-pushed
the
bugfix/share-dialog
branch
from
ff1e0c9
to
78c2990
Compare
|
PR title isn't clear |
mgallien
reviewed
Oct 11, 2021
camilasan
force-pushed
the
bugfix/share-dialog
branch
2 times, most recently
from
19832c1
to
f160744
Compare
|
/rebase |
nextcloud-command
force-pushed
the
bugfix/share-dialog
branch
from
f160744
to
3aecf0d
Compare
|
/rebase |
nextcloud-command
force-pushed
the
bugfix/share-dialog
branch
from
3aecf0d
to
7eafdd8
Compare
mgallien
reviewed
Oct 20, 2021
FlexW
reviewed
Oct 21, 2021
camilasan
force-pushed
the
bugfix/share-dialog
branch
2 times, most recently
from
f4e5f23
to
8b2cb8d
Compare
|
@camilasan looks good for me |
allexzander
reviewed
Oct 27, 2021
| @@ -628,7 +600,7 @@ void ShareLinkWidget::slotLinkContextMenuActionTriggered(QAction *action) | |||
| } | |||
| } | |||
|
|
|||
| void ShareLinkWidget::slotServerError(int code, const QString &message) | |||
| void ShareLinkWidget::slotServerError(const int code, const QString &message) | |||
There was a problem hiding this comment.
@camilasan Why are these const needed?
There was a problem hiding this comment.
they are not needed
a const is not usually needed but nice to have to improve readability
camilasan
force-pushed
the
bugfix/share-dialog
branch
from
8b2cb8d
to
bb0a7b8
Compare
Please check if this is a good enough cleaning. |
FlexW
approved these changes
Oct 27, 2021
|
/rebase |
added 3 commits
October 28, 2021 12:59
- Remove unecessary call to setupUiOptions after saving share password.
- Slot to create label: do not set it if nothing changed.
- Refactor showPasswordOptions, toggle/PasswordOptions/ExpireDateOptions/NoteOptions.
- Add const, auto and {} whenever possible.
- Refactor slotToggleButtonAnimation => toggleButtonAnimation.
Signed-off-by: Camila <hello@camila.codes>
Even after removing note from share link, the previous text was being displayed. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
nextcloud-command
force-pushed
the
bugfix/share-dialog
branch
from
bb0a7b8
to
d68b860
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: Nextcloud-PR-3863-d68b8604ac65dace235b1ca32f99bd328c101224-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I did #3794 and #3793, I thought I could clean a bit ShareLinkWidget... let me know what you think.