Fix BUILD_TESTING on non Linux unices #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
reviewed
Oct 12, 2021
|
@madpilot78 we will need you to rebase otherwise we cannot do a fast forward merge |
vfs_xattr is build only if LINUX is defined, but when building tests it is depended upon when UNIX is defined. This patch requires it only when LINUX is defined. Signed-off-by: Guido Falsi <mad@madpilot.net>
Rebased, hope I did everything correctly. |
|
AppImage file: Nextcloud-PR-3880-5667a6aad2acc5f396e5684b64fa76b44aff467a-x86_64.AppImage |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Oct 29, 2021
Upstream build system tries to include a Linux only library in the build when tests are enabled. This patch has already been accepted upstream. PR: 258119 Approved by: Maintiner timeout Obtained from: nextcloud/desktop#3880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vfs_xattr is build only if LINUX is defined, but when building tests it is depended upon when UNIX is defined.
This patch requires it only when LINUX is defined.