Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed wording of status message #3898

Merged
merged 2 commits into from Oct 23, 2021
Merged

Changed wording of status message #3898

merged 2 commits into from Oct 23, 2021

Conversation

rakekniven
Copy link
Member

The files themselves have no problem. The sync process has problems.

Signed-off-by: rakekniven 2069590+rakekniven@users.noreply.github.com

@rakekniven rakekniven requested a review from FlexW October 17, 2021 15:00
@FlexW
Copy link

FlexW commented Oct 18, 2021

@jancborchardt @nimishavijay what do you think?

@nimishavijay
Copy link
Member

Good point, I think something simpler can work. Something like "Some files could not be synced!" What do you think?

allexzander
allexzander requested changes Oct 19, 2021
View reviewed changes
src/gui/tray/syncstatussummary.cpp Outdated Show resolved Hide resolved
@allexzander
Copy link
Collaborator

Good point, I think something simpler can work. Something like "Some files could not be synced!" What do you think?

In fact, I prefer this version. @rakekniven

@rakekniven
Copy link
Member Author

Good point, I think something simpler can work. Something like "Some files could not be synced!" What do you think?

In fact, I prefer this version. @rakekniven

Works for me 👍 . Adapted PR.

@allexzander
Copy link
Collaborator

/rebase

@rakekniven @allexzander
Changed wording of status message
fb3c740 
The files themselves have no problem. The sync process has problems. 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@rakekniven @allexzander
Changed wording to suggestion
91884ee 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3898-91884eef4af925cf0e4ab1e5b53b57b190937c3d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit a444eb8 into master Oct 23, 2021
@allexzander allexzander deleted the rakekniven-patch-1 branch October 23, 2021 07:57
@mgallien mgallien added this to the 3.4.0 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@allexzander allexzander allexzander approved these changes

@FlexW FlexW FlexW approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@camilasan camilasan Awaiting requested review from camilasan

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rakekniven @FlexW @nimishavijay @allexzander @nextcloud-desktop-bot @mgallien