Don't do a connection checks when using push notifications #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
bugfix/pn-connection-check
branch
from
b54fe3e
to
e574569
Compare
mgallien
approved these changes
Nov 4, 2021
|
/rebase |
When using push notifications, it is not necessary to do regular connection checks because the push notifications will take care of it. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
nextcloud-command
force-pushed
the
bugfix/pn-connection-check
branch
from
e574569
to
d661e91
Compare
|
AppImage file: Nextcloud-PR-3948-d661e91a58dfa690f1909aa41bfe9c33f44d0701-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using push notifications, it is not necessary to do regular
connection checks because the push notifications will take care of it.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com
I will remove the log statements once the logic is ready.