Only build app bundle if requested #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
reviewed
Nov 17, 2021
camilasan
approved these changes
Nov 17, 2021
FlexW
pushed a commit
to nextcloud/client-building
that referenced
this pull request
Nov 17, 2021
After nextcloud/desktop#3983 gets merged, this variable needs to be set explicitly. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
|
/rebase |
nextcloud-command
force-pushed
the
bugfix/only-build-app-bundle-if-needed
branch
from
bd7bebf
to
c43ee96
Compare
|
Please make sure this one gets only merged after https://github.com/nextcloud-gmbh/brander/pull/516 was merged. Otherwise, Brander will break. |
|
/rebase |
For development a app bundle is not needed. The app bundle is only needed for distribution and macdeployqt takes a lot of time. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
nextcloud-command
force-pushed
the
bugfix/only-build-app-bundle-if-needed
branch
from
c43ee96
to
ec64246
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: Nextcloud-PR-3983-ec64246dc7f0f2b865ee2cb92f6996f15fd1eaaa-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For development a app bundle is not needed. The app bundle is only
needed for distribution and macdeployqt takes a lot of time.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com