properly query sync journal DB to know when to run fix for VFS #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
reviewed
Nov 19, 2021
mgallien
force-pushed
the
bugfix/runVfsFixOnlyOnce
branch
from
919b2c0
to
e2cb0d4
Compare
allexzander
approved these changes
Nov 19, 2021
the new method added to query the db is not working and so the fix for vfs is executed at each sync run the new method for bool was not really needed so let's just remove it (and that will make the usage of SqlQuery be correct Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/runVfsFixOnlyOnce
branch
from
e2cb0d4
to
f1d834d
Compare
|
AppImage file: Nextcloud-PR-3988-f1d834df8e7118585d1e0306eb274c51b62d26e9-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run
the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com