Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.4] Enforce VFS. Disable 'Make always available locally'. #4078

Merged
merged 2 commits into from Dec 14, 2021
Merged

[stable-3.4] Enforce VFS. Disable 'Make always available locally'. #4078

merged 2 commits into from Dec 14, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4073

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.4.1 milestone Dec 14, 2021
@allexzander
Copy link
Collaborator

/rebase

@allexzander
Enforce VFS. Disable 'Make always available locally'.
d2febdf 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Save folder settings to config when force-switching VFS.
92b302f 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4078-92b302fb377f75d06f838b390d84f17e0bc4f1a2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 44da2f2 into stable-3.4 Dec 14, 2021
@allexzander allexzander deleted the backport/4073/stable-3.4 branch December 14, 2021 16:20
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Emporea
Copy link

Emporea commented Dec 23, 2021

Do I understand correctly that an upgrade to 3.4.1 enforces VFS?

What would happen to a client if VFS is not available for Nextcloud Desktop, which seems to be exFAT for me?

@Emporea Emporea mentioned this pull request Dec 23, 2021
Closed
@allexzander
Copy link
Collaborator

@Emporea No. The VFS is not enforced unless the client is built with ENFORCE_VIRTUAL_FILES_SYNC_FOLDER option set to ON in NEXTCLOUD.cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan camilasan approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@allexzander @nextcloud-desktop-bot @Emporea @mgallien @camilasan