Use preprocessor directive rather than normal 'if' for UNNotification types #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
9 tasks
camilasan
approved these changes
Jul 12, 2022
|
/backport to stable-3.5 |
mgallien
approved these changes
Jul 15, 2022
claucambra
force-pushed
the
bugfix/pre-big-sur-compile
branch
from
132fef1
to
00ea2c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4720 +/- ##
=======================================
Coverage 56.42% 56.43%
=======================================
Files 138 138
Lines 17070 17070
=======================================
+ Hits 9632 9633 +1
+ Misses 7438 7437 -1
|
… types Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/pre-big-sur-compile
branch
from
00ea2c4
to
f8d79c3
Compare
|
AppImage file: Nextcloud-PR-4720-f8d79c389c4c15c067c1318a4f831cdf46550950-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in #4563 we added an if statement to only send UNNotification types depending on the macOS version it seems that one of the values we used is not available at all on prior macOS versions.
This preprocessor directive should therefore fix compile on macOS 10.14-10.15