Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileactivitylistmodel QML registration #4920

Merged
merged 1 commit into from Sep 10, 2022

Conversation

claucambra
Copy link
Collaborator

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra
Copy link
Collaborator Author

This does not need to be backported as the change that resulted in this was not backported

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #4920 (b3ccbe2) into master (a6867f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4920      +/-   ##
==========================================
+ Coverage   57.16%   57.18%   +0.02%     
==========================================
  Files         138      138              
  Lines       17135    17136       +1     
==========================================
+ Hits         9795     9799       +4     
+ Misses       7340     7337       -3     
Impacted Files Coverage Δ
src/common/syncjournaldb.cpp 78.17% <100.00%> (+0.31%) ⬆️
src/libsync/propagatedownload.cpp 65.03% <0.00%> (-0.15%) ⬇️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/fix-fileactivitylistmodel-qml-registration branch from 7006e9d to b3ccbe2 Compare September 10, 2022 09:17
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4920-b3ccbe28082baf55d22291bb3b4bc9d67804d0c4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit 8bd9738 into master Sep 10, 2022
@mgallien mgallien deleted the bugfix/fix-fileactivitylistmodel-qml-registration branch September 10, 2022 09:50
@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants