Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch back to upstream craft #5178

Merged
merged 2 commits into from Nov 15, 2022
Merged

switch back to upstream craft #5178

merged 2 commits into from Nov 15, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien

This comment was marked as off-topic.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #5178 (23b8da3) into master (075b681) will increase coverage by 0.01%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
+ Coverage   57.56%   57.57%   +0.01%     
==========================================
  Files         138      138              
  Lines       17399    17399              
==========================================
+ Hits        10016    10018       +2     
+ Misses       7383     7381       -2     
Impacted Files Coverage Δ
src/libsync/account.h 33.33% <ø> (ø)
src/libsync/bandwidthmanager.h 0.00% <ø> (ø)
src/libsync/bulkpropagatorjob.h 50.00% <ø> (ø)
src/libsync/discoveryphase.h 25.00% <ø> (ø)
src/libsync/localdiscoverytracker.h 0.00% <ø> (ø)
src/libsync/networkjobs.h 4.76% <ø> (ø)
src/libsync/owncloudpropagator.h 68.65% <ø> (ø)
src/libsync/progressdispatcher.h 0.00% <ø> (ø)
src/libsync/propagateupload.h 42.59% <ø> (ø)
src/libsync/pushnotifications.h 83.33% <ø> (ø)
... and 8 more

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5178-23b8da319fe3265ff2beeccc61048856d12d9f90-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 131938f into master Nov 15, 2022
@mgallien mgallien deleted the ci/followUpstreamCraft branch November 15, 2022 17:33
@mgallien mgallien added this to the 3.7.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants