Only show mnemonic request dialog when user explicitly wants to enable E2EE #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
changed the title
mgallien
reviewed
Nov 29, 2022
claucambra
force-pushed
the
feature/dont-spam-user-with-mnemonic-request
branch
from
bb3ab79
to
d03f39d
Compare
claucambra
force-pushed
the
feature/dont-spam-user-with-mnemonic-request
branch
from
d03f39d
to
001bfd6
Compare
mgallien
approved these changes
Dec 9, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
mgallien
force-pushed
the
feature/dont-spam-user-with-mnemonic-request
branch
from
001bfd6
to
3b60643
Compare
|
AppImage file: nextcloud-PR-5181-3b6064390cf0dd80aabb41fc39a023a05f7d7bc8-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the user getting spammed with annoying pop-ups on launch asking for the mnemonic when they have no intention of enabling encryption on their current system/account
Closes #4778
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com