Improve backup dark mode palette for Windows #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5298 +/- ##
==========================================
+ Coverage 57.58% 57.67% +0.09%
==========================================
Files 139 139
Lines 17595 17614 +19
==========================================
+ Hits 10132 10159 +27
+ Misses 7463 7455 -8
|
allexzander
approved these changes
Dec 29, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/windows-dark-palette
branch
from
bdd088d
to
9fd09b1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-5298-9fd09b125eef1dc0b801cb93a3c81d079ecdd41e-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our incomplete dark mode palette with a much better complete one taken from https://github.com/Jorgen-VikingGod/Qt-Frameless-Window-DarkStyle/ (thanks!)
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com