Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when local sync folder is overriden, respect this choice #5546

Merged
merged 1 commit into from Mar 31, 2023

Conversation

mgallien
Copy link
Collaborator

may lead to inadvertant data loss, not sure if that could be an issue

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #5546 (a3f87bd) into master (a7cf6c0) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head a3f87bd differs from pull request most recent head 622dbc0. Consider uploading reports for the commit 622dbc0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5546      +/-   ##
==========================================
+ Coverage   58.88%   58.89%   +0.01%     
==========================================
  Files         143      143              
  Lines       18331    18331              
==========================================
+ Hits        10794    10796       +2     
+ Misses       7537     7535       -2     

see 2 files with indirect coverage changes

@mgallien mgallien force-pushed the bugfix/overrideLocalDirReallyWithExistingFolder branch from a3f87bd to 622dbc0 Compare March 30, 2023 13:30
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5546-622dbc0a25c277cbab80a0556507e9a324b2cb44-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

may lead to inadvertant data loss, not sure if that could be an issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/overrideLocalDirReallyWithExistingFolder branch from 622dbc0 to 20422f0 Compare March 31, 2023 07:21
@mgallien mgallien merged commit a444564 into master Mar 31, 2023
7 of 9 checks passed
@mgallien mgallien deleted the bugfix/overrideLocalDirReallyWithExistingFolder branch March 31, 2023 07:22
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.8.0 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants