Fix undefined sync status reporting in tray icon #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.9 |
mgallien
requested changes
May 25, 2023
claucambra
force-pushed
the
bugfix/tray-sync-status-fix
branch
from
6ec2190
to
170b9f4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5565 +/- ##
==========================================
- Coverage 60.79% 60.36% -0.44%
==========================================
Files 145 143 -2
Lines 18836 18518 -318
==========================================
- Hits 11451 11178 -273
+ Misses 7385 7340 -45 |
|
SonarCloud Quality Gate failed. |
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com> f
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
mgallien
force-pushed
the
bugfix/tray-sync-status-fix
branch
from
170b9f4
to
d52ad2d
Compare
|
/backport to stable-3.12 |
mgallien
approved these changes
Feb 13, 2024
|
AppImage file: nextcloud-PR-5565-d52ad2d27bc1dbd9ea9a25c995111f63410c40b1-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some nice clean ups