Clean up systray.mm (macOS)

[claucambra]

The code here lacks constness, proper indentation, and uses old property accessing methods in Obj-C -- this can be improved with some basic changes :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #5602 (9c6e996) into master (a727971) will decrease coverage by 0.70%.
The diff coverage is n/a.

❗ Current head 9c6e996 differs from pull request most recent head 53cc438. Consider uploading reports for the commit 53cc438 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
- Coverage   60.08%   59.39%   -0.70%     
==========================================
  Files         145      143       -2     
  Lines       18762    18445     -317     
==========================================
- Hits        11274    10956     -318     
- Misses       7488     7489       +1     

see 57 files with indirect coverage changes

[allexzander]

@claucambra Nice one. Just check 1 tiny comment.

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5602-53cc438bf1ecad4bd45b317c04313040783528bc-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information