Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colouring of NCRadioButton #5786

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

claucambra
Copy link
Collaborator

Screenshot 2023-06-08 at 15 38 03

Screenshot 2023-06-08 at 15 38 00

Fixes #5781

@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@mgallien mgallien force-pushed the bugfix/ncradiobutton-dark-palette branch from 5e05186 to 2080577 Compare June 8, 2023 07:53
@mgallien mgallien enabled auto-merge June 8, 2023 07:53
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #5786 (beb651f) into master (f11a83c) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5786      +/-   ##
==========================================
+ Coverage   60.33%   60.37%   +0.03%     
==========================================
  Files         143      143              
  Lines       18530    18530              
==========================================
+ Hits        11181    11187       +6     
+ Misses       7349     7343       -6     

see 1 file with indirect coverage changes

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/ncradiobutton-dark-palette branch from 2080577 to beb651f Compare June 8, 2023 16:05
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5786-beb651fb053bd322d10471fb8dca9ab711a2147f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 7d8af35 into master Jun 8, 2023
13 checks passed
@mgallien mgallien deleted the bugfix/ncradiobutton-dark-palette branch June 8, 2023 17:56
@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: dark mode on mac os - can't see the view options
3 participants