Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] Bugfix/checksum calculation stop on destruction #5827

Merged
merged 1 commit into from Jun 20, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5688

… calculation thread on parent destruction.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #5827 (5b8c1ea) into stable-3.9 (499c9f2) will increase coverage by 0.08%.
The diff coverage is 85.29%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.9    #5827      +/-   ##
==============================================
+ Coverage       60.36%   60.44%   +0.08%     
==============================================
  Files             143      145       +2     
  Lines           18563    18609      +46     
==============================================
+ Hits            11205    11249      +44     
- Misses           7358     7360       +2     
Impacted Files Coverage Δ
src/common/checksums.h 0.00% <ø> (ø)
src/common/checksums.cpp 73.57% <60.00%> (-6.00%) ⬇️
src/common/checksumcalculator.cpp 87.64% <87.64%> (ø)
src/common/checksumcalculator.h 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.5% 75.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5827-5b8c1eaf86f9f02ca730776f050c8a0fcdb0f245-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 9d3ebff into stable-3.9 Jun 20, 2023
12 of 13 checks passed
@allexzander allexzander deleted the backport/5688/stable-3.9 branch June 20, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants