Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] prevent crash by resetting common pointer after deleting gobject menu #5850

Merged
merged 1 commit into from Jun 30, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5845

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #5850 (df4eeb6) into stable-3.9 (499c9f2) will increase coverage by 0.07%.
The diff coverage is 85.29%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.9    #5850      +/-   ##
==============================================
+ Coverage       60.36%   60.43%   +0.07%     
==============================================
  Files             143      145       +2     
  Lines           18563    18609      +46     
==============================================
+ Hits            11205    11246      +41     
- Misses           7358     7363       +5     
Impacted Files Coverage Δ
src/common/checksums.h 0.00% <ø> (ø)
src/common/checksums.cpp 73.57% <60.00%> (-6.00%) ⬇️
src/common/checksumcalculator.cpp 87.64% <87.64%> (ø)
src/common/checksumcalculator.h 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5850-df4eeb6368caa4b670e49fb076dd806babf68fc1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien enabled auto-merge June 30, 2023 13:43
@mgallien mgallien merged commit d50c32a into stable-3.9 Jun 30, 2023
13 checks passed
@mgallien mgallien deleted the backport/5845/stable-3.9 branch June 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants