Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] Remove seen Talk notificatios from Tray window. #5869

Merged
merged 1 commit into from Jul 6, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5851

Signed-off-by: alex-z <blackslayer4@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jul 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #5869 (6843441) into stable-3.9 (df4eeb6) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.9    #5869      +/-   ##
==============================================
- Coverage       60.43%   60.42%   -0.01%     
==============================================
  Files             145      145              
  Lines           18609    18609              
==============================================
- Hits            11246    11245       -1     
- Misses           7363     7364       +1     
Impacted Files Coverage Δ
src/common/filesystembase.cpp 76.43% <ø> (ø)
src/common/syncjournaldb.h 75.00% <ø> (ø)
src/common/syncjournalfilerecord.h 54.54% <ø> (ø)
src/common/utility.cpp 74.06% <ø> (ø)
src/common/utility.h 0.00% <ø> (ø)
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/accessmanager.cpp 88.88% <ø> (ø)
src/libsync/account.h 40.00% <ø> (ø)
src/libsync/bulkpropagatorjob.h 50.00% <ø> (ø)
src/libsync/capabilities.h 0.00% <ø> (ø)
... and 24 more

... and 1 file with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5869-68434412262b2b605b6637efe96174a4478c6dff-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit f5be46c into stable-3.9 Jul 6, 2023
11 of 13 checks passed
@allexzander allexzander deleted the backport/5851/stable-3.9 branch July 6, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants