fix bulk upload of empty files

[mgallien]

force an empty body when we bulk upload empty files

force a "valid" checksum to be computed for empty files as bulk upload server side expects a checksum even for empty files

Close #5824

[mgallien]

require also a fix from server nextcloud/server#39221

[mgallien]

/backport to stable-3.9

[allexzander]

@mgallien Looks nice, but I am still getting an error when syncing an empty file:

[WARNING] Could not complete propagation of "New Text Document (5).txt" by OCC::BulkPropagatorJob(0x2b23bd9f650) with status OCC::SyncFileItem::NormalError and error: "Network error: 302"
modify final status NormalError OCC::SyncFileItem::NormalError OCC::SyncFileItem::NormalError
[WARNING] Item "New Text Document (5).txt" retrieved resulted in "Network error: 302"
[WARNING] Item "New Text Document (5).txt" retrieved resulted in error "Network error: 302"

[mgallien]

@mgallien Looks nice, but I am still getting an error when syncing an empty file:

[WARNING] Could not complete propagation of "New Text Document (5).txt" by OCC::BulkPropagatorJob(0x2b23bd9f650) with status OCC::SyncFileItem::NormalError and error: "Network error: 302" modify final status NormalError OCC::SyncFileItem::NormalError OCC::SyncFileItem::NormalError [WARNING] Item "New Text Document (5).txt" retrieved resulted in "Network error: 302" [WARNING] Item "New Text Document (5).txt" retrieved resulted in error "Network error: 302"

there are server side changes needed for a full fix
see nextcloud/server#39221

[allexzander]

@mgallien Looks nice, but I am still getting an error when syncing an empty file:
[WARNING] Could not complete propagation of "New Text Document (5).txt" by OCC::BulkPropagatorJob(0x2b23bd9f650) with status OCC::SyncFileItem::NormalError and error: "Network error: 302" modify final status NormalError OCC::SyncFileItem::NormalError OCC::SyncFileItem::NormalError [WARNING] Item "New Text Document (5).txt" retrieved resulted in "Network error: 302" [WARNING] Item "New Text Document (5).txt" retrieved resulted in error "Network error: 302"

there are server side changes needed for a full fix see nextcloud/server#39221

got it, approved, but could not test of course

[codecov]

Codecov Report

Merging #5871 (5540f7f) into master (4cc1395) will increase coverage by 0.00%.
The diff coverage is 77.77%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5871   +/-   ##
=======================================
  Coverage   60.08%   60.08%           
=======================================
  Files         145      145           
  Lines       18715    18711    -4     
=======================================
- Hits        11244    11242    -2     
+ Misses       7471     7469    -2     

Impacted Files	Coverage Δ
src/libsync/putmultifilejob.cpp	88.46% <50.00%> (-3.38%)	⬇️
src/common/checksumcalculator.cpp	86.58% <100.00%> (-1.06%)	⬇️

... and 11 files with indirect coverage changes

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5871-5540f7f0f4dde32c874ddd6e20508ba911497c1b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[AndyXheli]

@mgallien do this also fix ? #5758 (comment) looks like the same issue to me ?