Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.9] Fix crash and incorrect implementation of seen chat notofications removal #5897

Merged
merged 2 commits into from Jul 18, 2023
Merged

[stable-3.9] Fix crash and incorrect implementation of seen chat notofications removal #5897

merged 2 commits into from Jul 18, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5879

allexzander and others added 2 commits July 18, 2023 08:57
@allexzander @backportbot-nextcloud
Fix crash in _finalList removal loop. Fix incorrect implementation of…
996847d 
… seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@mgallien @backportbot-nextcloud
try to force use of python 3.8 for windows as required by craft
4b833e3 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jul 18, 2023
@mgallien mgallien enabled auto-merge July 18, 2023 09:17
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5897 (4b833e3) into stable-3.9 (473fb2f) will decrease coverage by 0.11%.
The diff coverage is 53.57%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.9    #5897      +/-   ##
==============================================
- Coverage       60.54%   60.44%   -0.11%     
==============================================
  Files             145      145              
  Lines           18612    18640      +28     
==============================================
- Hits            11269    11267       -2     
- Misses           7343     7373      +30
Impacted Files Coverage Δ
src/libsync/abstractnetworkjob.cpp 72.24% <ø> (+1.14%) ⬆️
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/networkjobs.h 12.50% <0.00%> (-0.55%) ⬇️
src/libsync/networkjobs.cpp 60.07% <55.55%> (-0.17%) ⬇️

... and 3 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5897-4b833e3e92a1496fd29c72a17869e1b210c97318-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 18b64d3 into stable-3.9 Jul 18, 2023
11 of 13 checks passed
@mgallien mgallien deleted the backport/5879/stable-3.9 branch July 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra claucambra approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nextcloud-desktop-bot @mgallien @claucambra @allexzander