Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] Fix expire date field in Share settings #5907

Merged
merged 5 commits into from Jul 21, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5659

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5907 (da05abe) into stable-3.9 (470a983) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head da05abe differs from pull request most recent head 694d855. Consider uploading reports for the commit 694d855 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.9    #5907      +/-   ##
==============================================
+ Coverage       60.45%   60.46%   +0.01%     
==============================================
  Files             145      145              
  Lines           18650    18650              
==============================================
+ Hits            11274    11277       +3     
+ Misses           7376     7373       -3     

see 1 file with indirect coverage changes

@mgallien mgallien enabled auto-merge July 21, 2023 09:06
…, stop treating like menu which it used to be

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…reaks binding by editing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…tions when the expire date is forced back down to the same one being currently held

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…nput provided

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5907-694d8550acd5a94122fdcfa6830e52908b39ef5c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit 6a919bd into stable-3.9 Jul 21, 2023
10 of 11 checks passed
@mgallien mgallien deleted the backport/5659/stable-3.9 branch July 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants