Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.9] Fix build of sharemodel.cpp on MSVC #5913

Merged
merged 1 commit into from Jul 22, 2023
Merged

[stable-3.9] Fix build of sharemodel.cpp on MSVC #5913

merged 1 commit into from Jul 22, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5912

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jul 21, 2023
@mgallien mgallien enabled auto-merge July 21, 2023 16:15
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited

Codecov Report

Merging #5913 (6dfcc86) into stable-3.9 (1b57b31) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 6dfcc86 differs from pull request most recent head b54866f. Consider uploading reports for the commit b54866f to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.9    #5913      +/-   ##
==============================================
- Coverage       60.45%   60.41%   -0.04%     
==============================================
  Files             145      145              
  Lines           18653    18653              
==============================================
- Hits            11276    11269       -7     
- Misses           7377     7384       +7

see 2 files with indirect coverage changes

@claucambra @mgallien
Fix build of sharemodel.cpp on MSVC
b54866f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5913-b54866f70fbd5118ecfb8021aa1f4e66c818d05c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mgallien mgallien merged commit 0167fcd into stable-3.9 Jul 22, 2023
11 checks passed
@mgallien mgallien deleted the backport/5912/stable-3.9 branch July 22, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nextcloud-desktop-bot @allexzander @mgallien @claucambra