fixed detection of server version in cmd client similar to gui client:

[errror]

first check status.php for version and then capabilities, only use version string if not empty

this also fixes 'File names containing the character ":" are not supported on this file system.' errors in nextcloudcmd (on Linux): The invalidFilenameRegex was set to a static default in case the server version was not set correctly. As newer versions of nextcloud do not return the version in capabilities but status.php, the server version was empty.

Signed-off-by: Patrick Cernko errror@errror.org

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6016-f8650933ee8ff1700024a0eb0a4924c2efe6aef6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[claucambra]

Awesome, thanks!

[claucambra]

Hi, as soon as you remove the merge commit f865093 we can merge

[claucambra]

Also, please make sure your relevant commit is signed off :)

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6016-b177af9d4f6094093177d9b607ccfff127a4945d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[errror]

@claucambra I have no idea, what you are talking about when you say "remove the merge commit f865093". Could you please tell me, what I have to do and where?

Also how do I change my already done commit message? When I did the commit, I was not aware of the "signed off" requirement. Should I do a new fork and make the commit with the required "Signed-Off" signature?

[claucambra]

@claucambra I have no idea, what you are talking about when you say "remove the merge commit f865093". Could you please tell me, what I have to do and where?

You should rebase the commit on master and drop the merge commits (there are now two, f865093 and b177af9)

Also how do I change my already done commit message? When I did the commit, I was not aware of the "signed off" requirement. Should I do a new fork and make the commit with the required "Signed-Off" signature?

You should amend the commit with the --sign-off flag

[claucambra]

Once merge commits are removed, we can merge

[errror]

@claucambra I have no idea, what you are talking about when you say "remove the merge commit f865093". Could you please tell me, what I have to do and where?

You should rebase the commit on master and drop the merge commits (there are now two, f865093 and b177af9)

Also how do I change my already done commit message? When I did the commit, I was not aware of the "signed off" requirement. Should I do a new fork and make the commit with the required "Signed-Off" signature?

You should amend the commit with the --sign-off flag

[errror]

I have created a new PR to fullfil your requirements: 6023