Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhide discovery logs for file deleted on the server and for discovered file #6112

Merged
merged 1 commit into from Oct 5, 2023
Merged

Unhide discovery logs for file deleted on the server and for discovered file #6112

merged 1 commit into from Oct 5, 2023

Conversation

allexzander
Copy link
Collaborator

@allexzander allexzander commented Oct 3, 2023 •
edited

No description provided.

@allexzander allexzander changed the title Unhide discovery logs for file deleted on the server and for discover… Unhide discovery logs for file deleted on the server and for discovered file Oct 3, 2023
claucambra
claucambra requested changes Oct 3, 2023
View reviewed changes
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited

Codecov Report

Merging #6112 (623fe40) into master (8fbd6ef) will increase coverage by 0.21%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6112      +/-   ##
==========================================
+ Coverage   60.31%   60.53%   +0.21%     
==========================================
  Files         145      145              
  Lines       18800    18805       +5     
==========================================
+ Hits        11340    11384      +44     
+ Misses       7460     7421      -39
Files Coverage Δ
src/libsync/discovery.cpp 86.49% <100.00%> (+0.06%) ⬆️

... and 7 files with indirect coverage changes

@allexzander
Unhide discovery logs for file deleted on the server and for discover…
623fe40 
…ed file.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/unhide-some-discovery-logs branch from 4805e9a to 623fe40 Compare October 5, 2023 08:48
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6112-623fe40c3691ac8ea11424e9d869eb95e91061c4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 39eab0b into master Oct 5, 2023
12 of 14 checks passed
@allexzander allexzander deleted the feature/unhide-some-discovery-logs branch October 5, 2023 10:13
@allexzander
Copy link
Collaborator Author

/backport to stable-3.10

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 5, 2023
Merged
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien