ensure we do not modify a file that has been just uploaded

[mgallien]

No description provided.

[allexzander]

@mgallien The PR title mentions a file that has been uploaded, but in your code the changes are within if (item->_direction == SyncFileItem::Down) downloaded file, is this correct?

UPDATE: Also, SyncEngineTest has failed

[mgallien]

@mgallien The PR title mentions a file that has been uploaded, but in your code the changes are within if (item->_direction == SyncFileItem::Down) downloaded file, is this correct?

UPDATE: Also, SyncEngineTest has failed

basically the issue is that with group folders, when you upload a file, on the next sync, there will be an update metadata sync step from the server
on this down sync of metadata, we also update the mod time even if it is equal to the one from server
the result on windows is that you will truncate milliseconds from the modtime and will result in software thinking the file was modified

[sonarcloud]

Quality Gate failed

Failed conditions

1 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6297-0b869247effc59011c4d9ade2ba5412585dc610a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

/backport to stable-3.10

[mgallien]

/backport to stable-3.11