Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Exclude list. Fix stuck 'excluded' status in Windows Explorer after removing the exclude pattern. #6503

Merged
merged 2 commits into from Mar 5, 2024

Conversation

allexzander
Copy link
Collaborator

No description provided.

@allexzander
Copy link
Collaborator Author

/backport to stable-3.12

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add one/some automated tests just for this change ?
would give a better feel before approving

… after removing the exclude pattern.

Signed-off-by: alex-z <blackslayer4@gmail.com>
Signed-off-by: alex-z <blackslayer4@gmail.com>
@mgallien mgallien force-pushed the bugfix/ignorelist-exclude-status-stuck branch from c347864 to d29e5be Compare March 5, 2024 09:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6503-d29e5bee7a736dba493bc3f1f6ca37c76c68266a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 6bd4539 into master Mar 5, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/ignorelist-exclude-status-stuck branch March 5, 2024 11:17
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants