[socketapi] Replace QClipboard with KSystemClipboard when available #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
force-pushed
the
work/ervin/socketapi-use-ksystemclipboard-when-available
branch
from
7cb68ee
to
26fdcf2
Compare
|
Again it looks like we're having false positives on the macOS and Windows build. Also the issues sonar is pointing are unrelated to the code introduced here. |
camilasan
approved these changes
Mar 6, 2024
This will be needed to replace QClipboard in some places. Signed-off-by: Kevin Ottens <ervin@kde.org>
This is necessary in Wayland sessions for the clipboard related actions of the socketapi to work. Indeed, QClipboard does its job only if we got a window with the focus in such session. In the case of the socketapi, it is generally the file manager asking the desktop client to put something in the clipboard. At this point in time no window of the client have the focus, so nothing gets added to the clipboard. KSystemClipboard on the other hand, uses the wlr data control protocol under wayland sessions ensuring something ends up in the clipboard as expected. When not in a wayland session it falls back to QClipboard so no behavior is lost. Signed-off-by: Kevin Ottens <ervin@kde.org>
er-vin
force-pushed
the
work/ervin/socketapi-use-ksystemclipboard-when-available
branch
from
26fdcf2
to
526ab05
Compare
|
AppImage file: nextcloud-PR-6515-526ab056d67b2f3220365e709b6f753d0dcb0979-x86_64.AppImage |
|
mgallien
deleted the
work/ervin/socketapi-use-ksystemclipboard-when-available
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in Wayland sessions for the clipboard related actions of the socketapi to work. Indeed, QClipboard does its job only if we got a window with the focus in such session.
In the case of the socketapi, it is generally the file manager asking the desktop client to put something in the clipboard. At this point in time no window of the client have the focus, so nothing gets added to the clipboard.
KSystemClipboard on the other hand, uses the wlr data control protocol under wayland sessions ensuring something ends up in the clipboard as expected. When not in a wayland session it falls back to QClipboard so no behavior is lost.