Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if desktop client sent a first reply: wait for the menu data #6553

Merged

Conversation

mgallien
Copy link
Collaborator

may need the user to wait a bit longer but should prevent missing the context menu

should still be robust since we only wait indefinitely if desktop client sent a first reply

@mgallien mgallien force-pushed the bugfix/preventMissingContextMenuOnWindowsFileExplorer branch 2 times, most recently from 590b411 to 5b705d9 Compare March 19, 2024 09:45
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

shell_integration/windows/NCContextMenu/NCContextMenu.h Outdated Show resolved Hide resolved
shell_integration/windows/NCContextMenu/NCContextMenu.h Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

shell_integration/windows/NCUtil/CommunicationSocket.h Outdated Show resolved Hide resolved
shell_integration/windows/NCOverlays/NCOverlay.h Outdated Show resolved Hide resolved
shell_integration/windows/NCUtil/RemotePathChecker.h Outdated Show resolved Hide resolved
shell_integration/windows/NCOverlays/NCOverlay.h Outdated Show resolved Hide resolved
shell_integration/windows/NCUtil/CommunicationSocket.h Outdated Show resolved Hide resolved
shell_integration/windows/NCUtil/CommunicationSocket.h Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/preventMissingContextMenuOnWindowsFileExplorer branch 2 times, most recently from f51f73a to a396d1d Compare March 19, 2024 17:25
may need the user to wait a bit longer but should prevent missing the
context menu

should still be robust since we only wait indefinitely if desktop client
sent a first reply

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/preventMissingContextMenuOnWindowsFileExplorer branch from a396d1d to 4bf1b86 Compare March 20, 2024 08:44
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien mgallien merged commit 0da5e4a into master Mar 20, 2024
9 of 12 checks passed
@mgallien mgallien deleted the bugfix/preventMissingContextMenuOnWindowsFileExplorer branch March 20, 2024 08:49
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6553-4bf1b8604c572a7b7f582fc6bea7ef8a8c09c861-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants