Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the proper name when reading system exclude config file #6568

Merged
merged 1 commit into from
Mar 22, 2024
Merged

use the proper name when reading system exclude config file #6568

merged 1 commit into from
Mar 22, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Mar 22, 2024 •
edited
Loading

Close #6539

@mgallien
use the proper name when reading system exclude config file
634f007 
Close #6539

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/defaultIgnorePatternsShouldBeCorrect branch from ba46132 to 634f007 Compare March 22, 2024 09:41
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6568-634f00707470b1761337c9979b29987918a8ef6a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
6 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 38812ce into master Mar 22, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/defaultIgnorePatternsShouldBeCorrect branch March 22, 2024 16:26
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@backportbot backportbot bot mentioned this pull request Mar 27, 2024
Merged
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Ignores Files Dialog: clicking on Defaults results in bogux patterns
3 participants
@mgallien @nextcloud-desktop-bot @allexzander