Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context menu: do not recursively check pin and availability states #6573

Merged
merged 1 commit into from
Mar 27, 2024
Merged

context menu: do not recursively check pin and availability states #6573

merged 1 commit into from
Mar 27, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien force-pushed the bugfix/fasterContextMenuWindowsVirtualFiles branch from 8f3633c to 06969e7 Compare March 22, 2024 16:34
This was referenced Mar 24, 2024
Closed
Closed
@mgallien mgallien force-pushed the bugfix/fasterContextMenuWindowsVirtualFiles branch 2 times, most recently from a73f421 to 7f01185 Compare March 26, 2024 22:30
claucambra
claucambra approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick comments but otherwise LGTM

src/common/vfs.h Outdated Show resolved Hide resolved
src/common/vfs.h Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/fasterContextMenuWindowsVirtualFiles branch from 7f01185 to 79df156 Compare March 27, 2024 10:52
@mgallien
context menu: do not recursively check pin and availability states
608a435 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/fasterContextMenuWindowsVirtualFiles branch from 79df156 to 608a435 Compare March 27, 2024 10:59
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien mgallien merged commit b6ff0c5 into master Mar 27, 2024
9 of 12 checks passed
@mgallien mgallien deleted the bugfix/fasterContextMenuWindowsVirtualFiles branch March 27, 2024 11:02
@backportbot backportbot bot mentioned this pull request Mar 27, 2024
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6573-608a435d38fd1ddcbc3d096f431902bf44f282d8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)
21 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgallien @nextcloud-desktop-bot @claucambra